Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415881

Re: [PATCH 1/2] ARM: dts: exynos: Fix port nodes names for Exynos5250 Snow board

Show all headers | View raw

On 06/06/16 21:24, Javier Martinez Canillas wrote:
> Commit 5c9cbade0629 ("ARM: dts: exynos: Fix DTC unit name warnings in
> Exynos5250") fixed all the DTC warnings about mismatchs between unit
> names and reg properties in Exynos5250 boards DTS.
> 
> But unfortunately it also added a regression on the Exynos5250 Snow
> Chromebook when changing the port node names since the OF graph logic
> expects the port nodes to be always named 'port'.
> 
> The Documentation/devicetree/bindings/graph.txt binding document says
> that when there is more than one port, '#address-cells', '#size-cells'
> and 'reg' properties should be used to number the port nodes.
> 
> Fixes: 5c9cbade0629 ("ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250")
> Reported-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

I've tested this on top of -rc1, and it indeed fixes the display
initialization I was seeing. It then dies in a horrible way, but that's
a separate bug.

So for this patch:

Tested-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ARM: dts: exynos: Fix port nodes names for Snow and Peach Pit DTS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-06 22:30 +0200
  [PATCH 1/2] ARM: dts: exynos: Fix port nodes names for Exynos5250 Snow board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-06 22:30 +0200
    Re: [PATCH 1/2] ARM: dts: exynos: Fix port nodes names for Exynos5250  Snow board Marc Zyngier <marc.zyngier@arm.com> - 2016-06-07 10:50 +0200
  Re: [PATCH 0/2] ARM: dts: exynos: Fix port nodes names for Snow and  Peach Pit DTS Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-07 08:20 +0200

csiph-web