Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation
Date	2016-06-08 18:10 +0200
Message-ID	<rHOdj-2nA-3@gated-at.bofh.it> (permalink)
References	<rH8QO-Oc-9@gated-at.bofh.it> <rH8QO-Oc-33@gated-at.bofh.it> <rHGfL-5Ap-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 08, 2016 at 04:39:44PM +0900, Minchan Kim wrote:
> On Mon, Jun 06, 2016 at 03:48:31PM -0400, Johannes Weiner wrote:
> > @@ -832,9 +854,9 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
> >   * Add the passed pages to the LRU, then drop the caller's refcount
> >   * on them.  Reinitialises the caller's pagevec.
> >   */
> > -void __pagevec_lru_add(struct pagevec *pvec)
> > +void __pagevec_lru_add(struct pagevec *pvec, bool new)
> >  {
> > -	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
> > +	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, (void *)new);
> >  }
> 
> Just trivial:
> 
> 'new' argument would be not clear in this context what does it mean
> so worth to comment it, IMO but no strong opinion.

True, it's a little mysterious. I'll document it.

> Other than that,
> 
> Acked-by: Minchan Kim <minchan@kernel.org>

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation Johannes Weiner <hannes@cmpxchg.org> - 2016-06-06 22:00 +0200
  Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Rik van Riel <riel@redhat.com> - 2016-06-07 00:00 +0200
    Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Johannes Weiner <hannes@cmpxchg.org> - 2016-06-07 00:20 +0200
      Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Rik van Riel <riel@redhat.com> - 2016-06-07 03:20 +0200
        Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Johannes Weiner <hannes@cmpxchg.org> - 2016-06-07 16:00 +0200
      Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Michal Hocko <mhocko@kernel.org> - 2016-06-07 11:30 +0200
        Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Johannes Weiner <hannes@cmpxchg.org> - 2016-06-07 16:10 +0200
  Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Michal Hocko <mhocko@kernel.org> - 2016-06-07 12:00 +0200
  Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Minchan Kim <minchan@kernel.org> - 2016-06-08 09:40 +0200
    Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page  isolation Johannes Weiner <hannes@cmpxchg.org> - 2016-06-08 18:10 +0200

csiph-web