Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1414928

Re: [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function to return error

Show all headers | View raw

On 06/06/2016 12:51 PM, Krzysztof Kozlowski wrote:
> On 06/01/2016 10:34 AM, Daniel Lezcano wrote:
>> The init functions do not return any error. They behave as the following:
>>
>>   - panic, thus leading to a kernel crash while another timer may work and
>>     make the system boot up correctly
>>
>>   or
>>
>>   - print an error and let the caller unaware if the state of the system
>>
>> Change that by converting the init functions to return an error conforming
>> to the CLOCKSOURCE_OF_RET prototype.
>>
>> Proper error handling (rollback, errno value) will be changed later case
>> by case, thus this change just return back an error or success in the init
>> function.
>
> I don't see the benefits of this change alone. You are replacing one
> non-return code to another always-return-success code. The effect is
> exactly the same. It would make sense to change it to CLOCKSOURCE_OF_RET
> along with proper error handling.
>

Hi Krzysztof,

I can understand you expect an error handling but, as stated in the 
changelog, proper error handling will be done later. Currently, there 
are roughly 80 drivers to changes the init function to return a value in 
order change the CLOCKSOURCE_OF_DECLARE macro. That is a quite important 
number and changing also the internals will introduce bugs.

So the series (and there is a huge one coming right after this one), 
will focus only on changing the init function to return a value, so we 
can swap the clocksource table and rename CLOCKSOURCE_OF_DECLARE_RET 
without the '_RET'. I want this to be done before the next PR in order 
to prevent to have a double clksrc table.

If error handling is already taken into account and is trivial, I try to 
do the change, otherwise I let the function to return a success value.

Regarding the important number of drivers, if you have time to change 
the init function in the exynos_mct, that will be more than welcome :)

   -- Daniel




-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 10:40 +0200
  [PATCH 4/9] clocksource/drivers/mkt_timer: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 10:40 +0200
  [PATCH 8/9] clocksource/drivers/st_lpc: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 10:40 +0200
  [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 10:40 +0200
    Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init  function to return error Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-06-01 16:40 +0200
      Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init  function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 16:50 +0200
  [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:00 +0200
    Re: [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function  to return error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-06 13:00 +0200
      Re: [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function  to return error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-06 13:30 +0200
      Re: [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function  to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-06 13:30 +0200
  [PATCH 6/9] clocksource/drivers/asm9260: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:00 +0200
  [PATCH 1/9] of: Add a new macro to declare_of for one parameter function returning a value Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:00 +0200
  [PATCH 9/9] clocksource/drivers/dw_apb_timer: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:00 +0200
  [PATCH 3/9] clocksource/drivers/rockchip_timer: Convert init function to return error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:10 +0200
  [PATCH 2/9] clocksource/drivers/clksrc-probe: Introduce init functions with return code Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-01 11:10 +0200
  Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-07 12:00 +0200
    Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-07 13:40 +0200
    Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-08 00:30 +0200
    Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-08 16:20 +0200
      Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-09 09:50 +0200
        Re: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-09 09:50 +0200

csiph-web