Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413990

Re: [PATCH] net: ethernet: cavium: liquidio: response_manager: Remove create_workqueue

Show all headers | View raw

On Sat, Jun 04, 2016 at 08:21:40PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workitem viz
> (&cwq->wk.work which maps to oct_poll_req_completion) is involved
> in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
> forward progress under memory pressure, which is a requirement here.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary.
> 
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the call to flush_workqueue() has been dropped.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

As with the previous patch, the subject tag doesn't need to contain
the full hierarchy but other than that,

 Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: cavium: liquidio: response_manager: Remove  create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-04 17:00 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: response_manager:  Remove create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-05 12:30 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: response_manager:  Remove create_workqueue David Miller <davem@davemloft.net> - 2016-06-07 03:20 +0200

csiph-web