Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411864

RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

From Hayes Wang <hayeswang@realtek.com>
Newsgroups linux.kernel
Subject RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address
Date 2016-06-02 08:20 +0200
Message-ID <rFu94-2i2-11@gated-at.bofh.it> (permalink)
References <rFmlc-5Hs-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Mario Limonciello [mailto:mario_limonciello@dell.com]
[...]
>  static int set_ethernet_addr(struct r8152 *tp)
>  {
>  	struct net_device *dev = tp->netdev;
> @@ -1041,6 +1075,9 @@ static int set_ethernet_addr(struct r8152 *tp)
>  	else
>  		ret = pla_ocp_read(tp, PLA_BACKUP, 8, sa.sa_data);
> 
> +	/* if system provides auxiliary MAC address */
> +	set_auxiliary_addr(&sa);
> +
>  	if (ret < 0) {
>  		netif_err(tp, probe, dev, "Get ether addr fail\n");
>  	} else if (!is_valid_ether_addr(sa.sa_data)) {

When tp->version == RTL_VER_01, you would have different MAC address
between SW and HW. You may use the MAC address from ACPI for dev_addr.
However, the device uses another one, because you don't set it to the device.

Best Regards,
Hayes

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Mario Limonciello <mario_limonciello@dell.com> - 2016-06-02 00:00 +0200
  Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Andrew Lunn <andrew@lunn.ch> - 2016-06-02 00:30 +0200
    RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 00:40 +0200
      Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Greg KH <gregkh@linuxfoundation.org> - 2016-06-02 01:10 +0200
        RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 04:00 +0200
  Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Greg KH <gregkh@linuxfoundation.org> - 2016-06-02 01:10 +0200
    RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 04:20 +0200
      Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Greg KH <gregkh@linuxfoundation.org> - 2016-06-02 17:30 +0200
        RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 17:50 +0200
          Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Greg KH <gregkh@linuxfoundation.org> - 2016-06-02 18:10 +0200
            RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 19:00 +0200
              RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Hayes Wang <hayeswang@realtek.com> - 2016-06-03 11:30 +0200
                RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-03 17:00 +0200
          Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Bjørn Mork <bjorn@mork.no> - 2016-06-02 20:10 +0200
            RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 20:30 +0200
              Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Pali Rohár <pali.rohar@gmail.com> - 2016-06-02 21:10 +0200
                RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 21:20 +0200
            Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Pali Rohár <pali.rohar@gmail.com> - 2016-06-02 20:50 +0200
    RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 05:00 +0200
      Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Bjørn Mork <bjorn@mork.no> - 2016-06-02 10:20 +0200
        RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 16:30 +0200
    Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Bjørn Mork <bjorn@mork.no> - 2016-06-02 09:30 +0200
  RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Hayes Wang <hayeswang@realtek.com> - 2016-06-02 08:20 +0200
  Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Pali Rohár <pali.rohar@gmail.com> - 2016-06-02 09:50 +0200
    RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 16:50 +0200
      RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address <Mario_Limonciello@Dell.com> - 2016-06-02 17:10 +0200
      Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary  MAC address Andrew Lunn <andrew@lunn.ch> - 2016-06-02 17:10 +0200

csiph-web