Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412471
| From | Javi Merino <javi.merino@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() |
| Date | 2016-06-02 20:10 +0200 |
| Message-ID | <rFFe9-103-9@gated-at.bofh.it> (permalink) |
| References | <rFBtT-6Tw-5@gated-at.bofh.it> <rFBtT-6Tw-3@gated-at.bofh.it> <rFCgh-7bC-3@gated-at.bofh.it> <rFCSZ-7Dw-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 02, 2016 at 09:06:26PM +0530, Viresh Kumar wrote:
> On 2 June 2016 at 20:29, Javi Merino <javi.merino@arm.com> wrote:
> > In 5a31d594a973 ("cpufreq: Allow freq_table to be obtained for offline
> > CPUs") you did the opposite: don't use cpufreq_cpu_get_raw() because
> > it won't give you the policy of a cpu that is offline. Now you are
> > arguing that we should go back to cpufreq_cpu_get() which implicitly
> > calls cpufreq_cpu_get_raw(). Won't we hit the same issue that
> > 5a31d594a973 was trying to prevent: that we can't get a freq_table for
> > a cpu that is offline?
>
> Yes, that should be fixed. Thanks for letting me know about it :)
Ok, that was my only nit. Other than that, it looks good to me. For cpu_cooling.c
Acked-by: Javi Merino <javi.merino@arm.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:10 +0200
Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Javi Merino <javi.merino@arm.com> - 2016-06-02 17:00 +0200
Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 17:40 +0200
Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Javi Merino <javi.merino@arm.com> - 2016-06-02 20:10 +0200
Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-03 07:20 +0200
csiph-web