Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1408252

Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with smack enabled environment

Show all headers | View raw

On Fri, May 27, 2016 at 12:01:05PM -0700, Linus Torvalds wrote:

> Al, if you want Casey to help test, I think you should write out the
> full git repository address, rather than just say "See
> vfs.git#smack-fix".
> 
> Anybody who isn't used to pulling for you will just wonder where you
> keep your tree. And even I, who _am_ used to pulling from you, would
> have to look it up, so it's a lot more convenient if you actually
> write out the whole thing,

Point taken.

> Casey, Al is talking about
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs smack-fix
> 
> and Al, please make your commit messages more informative than just
> "switch ->setxattr() to passing dentry and inode separately". You can
> see that from the patch. Please add a _why_ something is done, not
> just what it does.

Umm...  Would something along the lines of

switch ->setxattr() to passing inode and dentry separately

smack ->d_instantiate() uses ->setxattr(), so to be able to call it before
we'd hashed the new dentry and attached it to inode, we ->setxattr() instances
get the inode as an explicit argument rather than obtaining it from dentry.
Similar change for ->getxattr() had been done commit ce23e64.  Unlike
->getxattr() (which is used both by selinux and smack instances of
->d_instantiate()) ->setxattr() is used only by smack one and unfortunately
it had been missed back then.

be detailed enough for the second one with

switch xattr_handler->set() to passing inode and dentry separately

preparation for similar switch in ->setxattr() (see the next commit for
rationale)

for the first one?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-05-27 13:10 +0200
  Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 17:20 +0200
    Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 21:00 +0200
      Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 21:10 +0200
        Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 21:30 +0200
          Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 21:40 +0200
            Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 21:50 +0200
              Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 21:50 +0200
                Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 22:30 +0200
                Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Casey Schaufler <casey@schaufler-ca.com> - 2016-05-28 00:50 +0200
                Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-05-30 03:50 +0200
      Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with  smack enabled environment Casey Schaufler <casey@schaufler-ca.com> - 2016-05-27 21:10 +0200
        Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path  with smack enabled environment Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-27 21:40 +0200

csiph-web