Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1408149

Re: [PATCH 1/3] pvclock: Add CPU barries to get correct version value

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] pvclock: Add CPU barries to get correct version value
Date 2016-05-27 17:50 +0200
Message-ID <rDsbo-5gf-15@gated-at.bofh.it> (permalink)
References <rDjhL-8fO-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote:
> Protocol for the "version" fields is: hypervisor raises it (making it
> uneven) before it starts updating the fields and raises it again (making
> it even) when it is done.  Thus the guest can make sure the time values
> it got are consistent by checking the version before and after reading
> them.
>
> Add CPU barries after getting version value just like what function
> vread_pvclock does, because all of callees in this function is inline.

LGTM.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] pvclock: Add CPU barries to get correct version value Minfei Huang <mnghuan@gmail.com> - 2016-05-27 08:20 +0200
  Re: [PATCH 1/3] pvclock: Add CPU barries to get correct version value Andy Lutomirski <luto@amacapital.net> - 2016-05-27 17:50 +0200

csiph-web