Re: [GIT PULL] Please pull NFS client changes for Linux 4.7

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] Please pull NFS client changes for Linux 4.7
Date	2016-05-28 02:20 +0200
Message-ID	<rDA8V-1UR-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

----- torvalds@linux-foundation.org wrote:

> On Fri, May 27, 2016 at 10:14 AM, Boris Ostrovsky
> <boris.ostrovsky@oracle.com> wrote:
> >
> > This breaks on older compilers:
> >
> >   CC      fs/nfs/nfs4state.o
> > /home/build/linux-linus/fs/nfs/nfs4state.c:69: error: unknown field
> > ‘data’ specified in initializer
> 
> Does the attached patch fix it for you?
> 
> I don't have easy access to the old compiler, but I _think_ the
> trivial patch of just adding braces around the data initializer
> should
> make old gcc's happy

It does fix it.

This is not the first time we've hit this and people have always been changing code to initialize fields in execution path (and I didn't fix it here myself because I wasn't sure where to do that). I guess we could have been just adding braces all along.

Thanks.
-boris

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] Please pull NFS client changes for Linux 4.7 Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-05-28 02:20 +0200
  Re: [GIT PULL] Please pull NFS client changes for Linux 4.7 Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-28 02:40 +0200

csiph-web