Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407498

Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration

Show all headers | View raw

Hi Stefano,

On 16/05/2016 12:11, Stefano Stabellini wrote:
> On Wed, 11 May 2016, Arnd Bergmann wrote:
>> A bugfix patch for the xen balloon driver introduced a forward
>> declaration for a static function that is conditionally compiled,
>> causing a warning if only the declaration but not the definition
>> are there:
>>
>> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
>>  static void release_memory_resource(struct resource *resource);
>>
>> This removes the declaration again and instead moves the function
>> definition to the right place, before its first caller and inside
>> of the #ifdef protecting both.
>>
>> The patch that introduced the warning is marked for stable
>> backports, so if that gets applied to 4.4, so should this one.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
>> Cc: stable@vger.kernel.org
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

You have applied this patch to the branch for-linus-4.8 but not 
for-linus-4.7. Is it intentional?

Regards,

-- 
Julien Grall

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] xen: remove incorrect forward declaration Stefano Stabellini <sstabellini@kernel.org> - 2016-05-16 13:20 +0200
  Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration Julien Grall <julien.grall@arm.com> - 2016-05-26 12:20 +0200
    Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration Stefano Stabellini <sstabellini@kernel.org> - 2016-05-26 12:20 +0200

csiph-web