Re: [PATCH 0/4] dma-mapping: Constify dma_attrs

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] dma-mapping: Constify dma_attrs
Date	2016-05-25 14:40 +0200
Message-ID	<rCGgp-Yf-1@gated-at.bofh.it> (permalink)
References	<rCe0N-89R-1@gated-at.bofh.it> <rCgFk-1o2-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction.  The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags.  This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.

The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:

#define	DMA_ATTR_WRITE_BARRIER		0x0001u
#define DMA_ATTR_WEAK_ORDERING		0x0002u
#define DMA_ATTR_WRITE_COMBINE		0x0004u
...

The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.

If that seems reasonable, I will send a follow up with new approach.

Thanks for feedback!

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-24 08:30 +0200
  [PATCH 3/4] arm64: dma-mapping: Constify attrs passed to internal  functions Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-24 08:30 +0200
  [PATCH 2/4] ARM: dma-mapping: Constify attrs passed to internal  functions Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-24 08:30 +0200
    Re: [PATCH 2/4] ARM: dma-mapping: Constify attrs passed to internal  functions Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-24 10:40 +0200
  [PATCH 1/4] dma-mapping: Constify attrs passed to dma_get_attr Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-24 08:30 +0200
  [RFC 4/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-24 08:30 +0200
  Re: [PATCH 0/4] dma-mapping: Constify dma_attrs Christoph Hellwig <hch@infradead.org> - 2016-05-24 11:20 +0200
    Re: [PATCH 0/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-25 14:40 +0200

csiph-web