Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1350679

Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct device

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct device
Date 2016-03-05 00:40 +0100
Message-ID <r97ua-5TD-1@gated-at.bofh.it> (permalink)
References <r38sY-5EQ-37@gated-at.bofh.it> <r3BbA-11x-23@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Thu, Feb 18, 2016 at 11:03:31AM -0700, Jason Gunthorpe wrote:
> > +	INIT_LIST_HEAD(&resources);
> > +	rc = acpi_dev_get_resources(device, &resources, crb_check_resource,
> > +				    priv);
> > +	if (rc < 0)
> > +		return rc;
> > +	acpi_dev_free_resource_list(&resources);
> 
> I wonder if the acpi_dev_free_resource_list is what kill's the
> resource name? Maybe that needs to be delayed until after the
> ioremap, which is best done with this back in crb_map_io  ??
> 
> Thanks for looking at this stuff,

I had almost forgotten this comment. I'll try this out as soon as
possible. Might well be the reason.

> Jason

/Jarkko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct  device Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-05 00:40 +0100

csiph-web