Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1
Date	2016-03-01 17:00 +0100
Message-ID	<r7USl-2ET-1@gated-at.bofh.it> (permalink)
References	<r55TX-3fB-3@gated-at.bofh.it> <r55TY-3fB-15@gated-at.bofh.it> <r7UfE-2na-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-03-01 at 15:13 +0000, Moore, Robert wrote:
> 
> > -----Original Message-----
> > From: Toshi Kani [mailto:toshi.kani@hpe.com]
> > Sent: Monday, February 22, 2016 1:55 PM
> > To: rjw@rjwysocki.net; Williams, Dan J
> > Cc: Moore, Robert; Zheng, Lv; elliott@hpe.com; linux-nvdimm@lists.01.or
> > g;
> > linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org;
> > devel@acpica.org; Toshi Kani
> > Subject: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to
> > comply ACPI 6.1
> > 
> > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as
> > follows.
> >  - Valid Fields, Manufacturing Location, and Manufacturing Date
> >    are added from reserved range.  No change in the structure size.
> >  - IDs defined as SPD values are arrays of bytes.  The spec
> >    clarified that they need to be represented as arrays of bytes
> >    as well.
> > 
> > This patch makes the following changes to support this update.
> >  - Change 'struct acpi_nfit_control_region' to reflect the update.
> >    SPD IDs are defined as arrays of bytes, so that they can be
> >    treated in the same way regardless of CPU endianness and are
> >    not miss-treated as little-endian numeric values.
> 
> 
> I don't think we are going to start changing the ACPI tables defined in
> the ACPICA headers because of this. We do in fact have macros for this
> purpose.

Can you elaborate what macros you suggest to use for this purpose?

Thanks,
-Toshi

Thread

RE: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 "Moore, Robert" <robert.moore@intel.com> - 2016-03-01 16:20 +0100
  Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Toshi Kani <toshi.kani@hpe.com> - 2016-03-01 17:00 +0100
    RE: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 "Moore, Robert" <robert.moore@intel.com> - 2016-03-01 17:10 +0100
      Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Toshi Kani <toshi.kani@hpe.com> - 2016-03-01 18:10 +0100
        RE: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 "Moore, Robert" <robert.moore@intel.com> - 2016-03-01 18:40 +0100
          RE: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 "Moore, Robert" <robert.moore@intel.com> - 2016-03-01 18:50 +0100
          Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Toshi Kani <toshi.kani@hpe.com> - 2016-03-01 19:40 +0100
        Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Dan Williams <dan.j.williams@intel.com> - 2016-03-01 19:20 +0100
          Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Toshi Kani <toshi.kani@hpe.com> - 2016-03-01 19:50 +0100
          Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to  comply ACPI 6.1 Toshi Kani <toshi.kani@hpe.com> - 2016-03-01 20:40 +0100

csiph-web