Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346148
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey |
| Date | 2016-02-29 21:40 +0100 |
| Message-ID | <r7CLM-7QV-9@gated-at.bofh.it> (permalink) |
| References | <r2PgC-KD-5@gated-at.bofh.it> <r7vKk-3rD-31@gated-at.bofh.it> <r7CLM-7QV-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Monday 29 February 2016 21:31:23 Michał Kępień wrote:
> > > diff --git a/drivers/platform/x86/dell-wmi.c
> > > b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5 100644
> > > --- a/drivers/platform/x86/dell-wmi.c
> > > +++ b/drivers/platform/x86/dell-wmi.c
> > > @@ -111,7 +111,7 @@ static const struct key_entry
> > > dell_wmi_legacy_keymap[] __initconst = {
> > >
> > > { KE_IGNORE, 0xe020, { KEY_MUTE } },
> > >
> > > /* Shortcut and audio panel keys */
> > >
> > > - { KE_IGNORE, 0xe025, { KEY_RESERVED } },
> > > + { KE_KEY, 0xe025, { KEY_PROG4 } },
> > >
> > > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> > >
> > > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
> > >
> > > @@ -235,6 +235,9 @@ static void dell_wmi_process_key(int
> > > reported_key)
> > >
> > > acpi_video_handles_brightness_key_presses())
> > >
> > > return;
> > >
> > > + if (key->keycode == KEY_PROG4 && !wmi_requires_smbios_request)
> > > + return;
> > > +
> >
> > Here I would rather test against reported_key, not keycode. If
> > somebody in future adds KEY_PROG4 for something else we will have
> > problem...
>
> As 0xe025 is currently the only event we know about that should be
> ignored on some machines and processed on others, this makes sense,
> at least for now. If I change the first condition to:
>
> reported_key == 0xe025
There will be need also change for 5/5 patch...
> will you be okay with adding your Reviewed-by for this patch? Then,
> for Darren's convenience, I could post a v5 of the whole series with
> the above change and all your Acked-by and Reviewed-by tags added.
This is my suggestion as I'm thinking about future changes to this
driver... But it is also on Darren as maintainer of platform x86
subsystem.
Basically you do not want to check if pressed key is KEY_PROG4. But you
want to check if dell wmi sent event 0xe025. This is what I say.
--
Pali Rohár
pali.rohar@gmail.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/5] Process Dell Instant Launch hotkey on Vostro V131 and Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:20 +0100
[PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:20 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 14:00 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień <kernel@kempniu.pl> - 2016-02-29 21:30 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 21:30 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień <kernel@kempniu.pl> - 2016-02-29 21:50 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Darren Hart <dvhart@infradead.org> - 2016-03-01 00:00 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień <kernel@kempniu.pl> - 2016-03-02 12:50 +0100
Re: [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Pali Rohár <pali.rohar@gmail.com> - 2016-03-03 12:40 +0100
[PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:20 +0100
Re: [PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 14:10 +0100
[PATCH v4 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:20 +0100
Re: [PATCH v4 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 14:00 +0100
[PATCH v4 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:30 +0100
Re: [PATCH v4 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 14:00 +0100
[PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień <kernel@kempniu.pl> - 2016-02-24 08:30 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 14:10 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień <kernel@kempniu.pl> - 2016-02-29 21:40 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 21:40 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień <kernel@kempniu.pl> - 2016-02-29 21:50 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Pali Rohár <pali.rohar@gmail.com> - 2016-02-29 22:00 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Darren Hart <dvhart@infradead.org> - 2016-03-01 00:10 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień <kernel@kempniu.pl> - 2016-03-02 13:40 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Darren Hart <dvhart@infradead.org> - 2016-03-03 18:20 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień <kernel@kempniu.pl> - 2016-03-03 19:50 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Darren Hart <dvhart@infradead.org> - 2016-03-03 21:50 +0100
Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Darren Hart <dvhart@infradead.org> - 2016-03-01 00:10 +0100
csiph-web