[PATCH 3/5] perf hists browser: Cleanup hist_browser__update_percent_limit()

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 3/5] perf hists browser: Cleanup hist_browser__update_percent_limit()
Date	2016-02-26 13:20 +0100
Message-ID	<r6pxg-331-13@gated-at.bofh.it> (permalink)
References	<r6pxg-331-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The previous patch introduced __rb_hierarchy_next() function with
various move direction like HMD_FORCE_CHILD but missed to change using
it some place.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/ui/browsers/hists.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 6bcd7670ce5f..904eaa719eb3 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2477,12 +2477,7 @@ static void hist_browser__update_percent_limit(struct hist_browser *hb,
 				     min_callchain_hits, &callchain_param);
 
 next:
-		/*
-		 * Tentatively set unfolded so that the rb_hierarchy_next()
-		 * can toggle children of folded entries too.
-		 */
-		he->unfolded = he->has_children;
-		nd = rb_hierarchy_next(nd);
+		nd = __rb_hierarchy_next(nd, HMD_FORCE_CHILD);
 
 		/* force to re-evaluate folding state of callchains */
 		he->init_have_children = false;
-- 
2.7.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] perf hists browser: Cleanup hist_browser__update_percent_limit() Namhyung Kim <namhyung@kernel.org> - 2016-02-26 13:20 +0100
  [tip:perf/core] perf hists browser: Cleanup  hist_browser__update_percent_limit() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-27 10:50 +0100

csiph-web