Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date	2016-02-20 09:10 +0100
Message-ID	<r4aM2-28b-21@gated-at.bofh.it> (permalink)
References	(2 earlier) <r36Ku-4qr-37@gated-at.bofh.it> <r3bh9-7Ch-29@gated-at.bofh.it> <r3AIy-yZ-29@gated-at.bofh.it> <r3UQV-6RV-5@gated-at.bofh.it> <r3XlL-hr-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Feb 19, 2016 at 10:44:34AM -0700, Jason Gunthorpe wrote:
> On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote:
> 
> > Can you quickly check the two top-most patches:
> > 
> > https://github.com/jsakkine/linux-tpmdd/commits/master
> 
> Drop the change to crb_map_res, the memset is not needed.

Left-over from when I tried to catch the issue. Removed.

> The shutdown change is probably OK for a rc fix, but it is still wrong.
> The shutdown has to be done inside the code after the core has removed
> all access to the tpm but before it has torn down so much that the
> driver doesn't work anymore.

I made the modifications you asked and run my smoke tests. Can I apply
your Reviewed-by's?

> Jason

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm_crb: fix bad name pointer usage with struct resource Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-17 01:30 +0100
  Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-17 06:00 +0100
    Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-17 10:40 +0100
      Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-17 15:30 +0100
        Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-18 18:40 +0100
          Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-19 16:10 +0100
            Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-19 18:50 +0100
              Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with  struct resource Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-20 09:10 +0100

csiph-web