Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example
Date	2016-02-22 12:20 +0100
Message-ID	<r4WH1-4WG-49@gated-at.bofh.it> (permalink)
References	(3 earlier) <r4lR7-2q1-1@gated-at.bofh.it> <r4oFk-4B6-9@gated-at.bofh.it> <r4GsA-16v-43@gated-at.bofh.it> <r4VBi-42I-29@gated-at.bofh.it> <r4Wxk-4RK-37@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

SeongJae Park <sj38.park@gmail.com> wrote:

> From f7b5677790771599f418f1d95536935be971ae86 Mon Sep 17 00:00:00 2001
> From: SeongJae Park <sj38.park@gmail.com>
> Date: Mon, 22 Feb 2016 19:26:18 +0900
> Subject: [PATCH] Documentation/memory-barriers: polish compiler store omit
>  example
> 
> Comments of examples about compiler store omit in memory-barriers.txt is
> about code that could be possible at that point.  However, someone could
> interpret the comment as an explanation about below line.  This commit
> exploits the intent more explicitly by changing the comment to be seems
> like a possible code rather than explanation about below line.
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  Documentation/memory-barriers.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/memory-barriers.txt
> b/Documentation/memory-barriers.txt
> index 904ee42..dc66351 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -1459,7 +1459,7 @@ of optimizations:
>       the following:
> 
>         a = 0;
> -       /* Code that does not store to variable a. */
> +       ... Code that does not store to variable a ...
>         a = 0;
> 
>       The compiler sees that the value of variable 'a' is already zero, so
> @@ -1471,7 +1471,7 @@ of optimizations:
>       wrong guess:
> 
>         WRITE_ONCE(a, 0);
> -       /* Code that does not store to variable a. */
> +       ... Code that does not store to variable a ...
>         WRITE_ONCE(a, 0);
> 
>   (*) The compiler is within its rights to reorder memory accesses unless

Acked-by: David Howells <dhowells@redhat.com>

Thread

[PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-20 07:10 +0100
  Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-20 21:00 +0100
    Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-21 00:00 +0100
      Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-21 19:00 +0100
        Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example David Howells <dhowells@redhat.com> - 2016-02-22 11:10 +0100
          Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example SeongJae Park <sj38.park@gmail.com> - 2016-02-22 12:10 +0100
            Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example David Howells <dhowells@redhat.com> - 2016-02-22 12:20 +0100
              Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-22 17:40 +0100
                Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-22 22:50 +0100
      Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-22 03:40 +0100

csiph-web