Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337971

Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button
Date 2016-02-19 09:40 +0100
Message-ID <r3OLw-2j4-11@gated-at.bofh.it> (permalink)
References <r34Sm-39G-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Feb 17, 2016 at 8:28 AM, qiujiang <qiujiang@huawei.com> wrote:

> This patch modifies the DesignWare GPIO controller driver to
> support the GPIO-signaled ACPI Events. This is used for power
> button function on ARM server.
>
> To make it work, the _AEI and _EVT object must be defined in
> the corresponding GPIO driver's dsdt table in UEFI as follow:
>
> Device(GPI0) {
>         Name(_HID, "HISI0181")
>         Name(_ADR, 0) // _ADR: Address
>         Name(_UID, 0)
>
>         Name (_CRS, ResourceTemplate ()  {
>                 Memory32Fixed (ReadWrite, 0x802e0000, 0x10000)
>                 Interrupt (ResourceConsumer, Level, ActiveHigh,
>                 Exclusive,,,) {344}
>         })
>
>         Device(PRTa) {
>                 Name (_DSD, Package () {
>                         Package () {
>                                 Package () {"reg",0},
>                                 Package () {"snps,nr-gpios",32},
>                 }
>                 })
>         }
>
>         Name (_AEI, ResourceTemplate () {
>                 GpioInt(Edge, ActiveLow, ExclusiveAndWake, PullUp, ,
>                 " \\_SB.GPI0") {8}
>         })
>
>         Method (_E08, 0x0, NotSerialized) {
>                 Notify (\_SB.PWRB, 0x80)
>         }
> }
>
> Signed-off-by: qiujiang <qiujiang@huawei.com>

This patch doesn't apply to my tree. Please do the following:

- Rebase on the "devel" branch in the linux-gpio tree:
  https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel

- Split in two parts as suggested by Andy S.

- Add Mika's ACKs.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button qiujiang <qiujiang@huawei.com> - 2016-02-17 08:40 +0100
  Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events  support for power button Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-02-17 10:00 +0100
  Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events  support for power button Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-17 15:50 +0100
  Re: [PATCH v1] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events  support for power button Linus Walleij <linus.walleij@linaro.org> - 2016-02-19 09:40 +0100

csiph-web