[PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup

From	Anand Moon <linux.amoon@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup
Date	2016-02-19 06:20 +0100
Message-ID	<r3LDY-8wv-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Anand Moon <linux.amoon@gmail.com>

drop the spin_unlock/lock around uart_write_wakeup to protect
write wakeup for uart port.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
changes logs: drop the previous approch of spin_unlock_irqrestore/save
---
 drivers/tty/serial/samsung.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index d72cd73..0cb70a9 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -758,11 +758,8 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id)
 		goto out;
 	}
 
-	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
-		spin_unlock(&port->lock);
+	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
 		uart_write_wakeup(port);
-		spin_lock(&port->lock);
-	}
 
 	if (uart_circ_empty(xmit))
 		s3c24xx_serial_stop_tx(port);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Anand Moon <linux.amoon@gmail.com> - 2016-02-19 06:20 +0100
  Re: [PATCHv2] serial: samsung: drop the spinlock around  uart_write_wakeup Peter Hurley <peter@hurleysoftware.com> - 2016-02-19 20:40 +0100
    Re: [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Anand Moon <linux.amoon@gmail.com> - 2016-02-20 04:40 +0100
    Re: [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-21 02:40 +0100
      Re: [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Anand Moon <linux.amoon@gmail.com> - 2016-02-21 04:10 +0100
        Re: [PATCHv2] serial: samsung: drop the spinlock around  uart_write_wakeup Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-22 01:10 +0100
          Re: [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Anand Moon <linux.amoon@gmail.com> - 2016-02-22 04:40 +0100

csiph-web