Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336177

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

Show all headers | View raw

Hi, Rob

On 2016年02月15日 15:15, Wei Ni wrote:
> Hi, Rob
> 
> On 2016年02月12日 22:42, Rob Herring wrote:
>> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni <wni@nvidia.com> wrote:
>>> Add hw-trips sub-node for soctherm, which is
>>> used to describe the hardware trip points for
>>> each soctherm sensors.
>>
>> I still don't understand why you are doing something custom here.
>> What's wrong with what is defined in:
>>
>> Documentation/devicetree/bindings/thermal/thermal.txt

I think it's better to add a .set_trip_temp for of-thermal's
thermal_zone_of_device_ops{}, so that we can set trip points on hardware. I'm
preparing patches, and will send out next version.
Thanks for your comments.

> 
> In current thermal framework, it support to set trip points for the thermal
> zones, but this trip point is handled by SW, doesn't have callbacks to program
> the hardware.
> There had patches:
> [PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points,
> http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html,
> which can support to program hardware to set trip points, but it seems this
> series didn't be taken.
> So I add this hw-trip-points sub-node for soctherm.
> 
> Hi, Sascha Hauer
> 
> Thanks.
> Wei.
> 
>>
>> Rob
>>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm Rob Herring <robh@kernel.org> - 2016-02-12 15:50 +0100
  Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm Wei Ni <wni@nvidia.com> - 2016-02-15 08:20 +0100
    Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm Wei Ni <wni@nvidia.com> - 2016-02-15 08:30 +0100
    Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm Wei Ni <wni@nvidia.com> - 2016-02-17 10:50 +0100
      Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm Matt Longnecker <mlongnecker@nvidia.com> - 2016-02-17 22:00 +0100

csiph-web