[PATCH] [media] v4l2-async: Don't fail if registered_async isn't implemented

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] [media] v4l2-async: Don't fail if registered_async isn't implemented
Date	2016-02-16 20:00 +0100
Message-ID	<r2T0R-3ha-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
core calls the registered_async callback but if a sub-dev driver does
not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
should not be considered an error.

Reported-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/media/v4l2-core/v4l2-async.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index 716bfd47daab..4d809115ba49 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -113,7 +113,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
 	list_move(&sd->async_list, &notifier->done);
 
 	ret = v4l2_device_register_subdev(notifier->v4l2_dev, sd);
-	if (ret < 0) {
+	if (ret < 0 && ret != -ENOIOCTLCMD) {
 		if (notifier->unbind)
 			notifier->unbind(notifier, sd, asd);
 		return ret;
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] v4l2-async: Don't fail if registered_async isn't implemented Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-16 20:00 +0100
  Re: [PATCH] [media] v4l2-async: Don't fail if registered_async isn't  implemented Benoit Parrot <bparrot@ti.com> - 2016-02-16 21:00 +0100
    Re: [PATCH] [media] v4l2-async: Don't fail if registered_async isn't  implemented Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-16 21:10 +0100

csiph-web