Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332956

Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11

From Andrew Duggan <aduggan@synaptics.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11
Date 2016-02-12 18:30 +0100
Message-ID <r1pHA-1zz-7@gated-at.bofh.it> (permalink)
References <r0LqQ-8kt-75@gated-at.bofh.it> <r1o8O-tk-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/12/2016 07:47 AM, Rob Herring wrote:
> On Wed, Feb 10, 2016 at 02:24:34PM -0800, Andrew Duggan wrote:
>> 2D sensors have several parameter which can be set in the platform data.
>> This patch adds support for getting those values from devicetree.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
>> ---
>>   .../bindings/input/rmi4/rmi_2d_sensor.txt          |  56 +++++++++++
>>   .../bindings/input/touchscreen/touchscreen.txt     |   2 +
>>   drivers/input/rmi4/rmi_2d_sensor.c                 | 108 +++++++++++++++++++++
>>   drivers/input/rmi4/rmi_2d_sensor.h                 |   3 +
>>   drivers/input/rmi4/rmi_f11.c                       |   7 +-
>>   5 files changed, 175 insertions(+), 1 deletion(-)
>>   create mode 100644 Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> index ac23caf..d6674de 100644
>> --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> @@ -18,6 +18,8 @@ Optional properties for Touchscreens:
>>    - touchscreen-inverted-y	: Y axis is inverted (boolean)
>>    - touchscreen-swapped-x-y	: X and Y axis are swapped (boolean)
>>   				  Swapping is done after inverting the axis
>> + - touchscreen-mm-x		: horizontal length in mm of the touchscreen
>> + - touchscreen-mm-y		: vertical length in mm of the touchscreen
> As I mentioned on v3, put the units on the end.

Oh sorry! I see you did mention that in v3 and I must have missed it.

Thanks,
Andrew

> Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11 Andrew Duggan <aduggan@synaptics.com> - 2016-02-10 23:30 +0100
  Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support  for 2d sensors and F11 Rob Herring <robh@kernel.org> - 2016-02-12 16:50 +0100
    Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support  for 2d sensors and F11 Andrew Duggan <aduggan@synaptics.com> - 2016-02-12 18:30 +0100

csiph-web