[PATCH] ath10k: fix erroneous return value

From	Anton Protopopov <a.s.protopopov@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] ath10k: fix erroneous return value
Date	2016-02-10 18:00 +0100
Message-ID	<r0Ght-4Nm-29@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The ath10k_pci_hif_exchange_bmi_msg() function may return the positive
value EIO instead of -EIO in case of error.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index ee925c6..526acde 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar,
 					    DMA_FROM_DEVICE);
 		ret = dma_mapping_error(ar->dev, resp_paddr);
 		if (ret) {
-			ret = EIO;
+			ret = -EIO;
 			goto err_req;
 		}
 
-- 
2.6.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ath10k: fix erroneous return value Anton Protopopov <a.s.protopopov@gmail.com> - 2016-02-10 18:00 +0100
  Re: [PATCH] ath10k: fix erroneous return value Julian Calaby <julian.calaby@gmail.com> - 2016-02-12 00:30 +0100

csiph-web