[PATCH v2 3/3] n_tty: Reduce branching in canon_copy_from_read_buf()

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/3] n_tty: Reduce branching in canon_copy_from_read_buf()
Date	2015-11-27 20:20 +0100
Message-ID	<qzwIN-6VB-13@gated-at.bofh.it> (permalink)
References	<qszip-1jV-7@gated-at.bofh.it> <qzwIN-6VB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Instead of compare-and-set, just compute 'found'.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/n_tty.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index eab606a..9b0b610 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -2079,10 +2079,9 @@ static int canon_copy_from_read_buf(struct tty_struct *tty,
 	if (eol == N_TTY_BUF_SIZE && more) {
 		/* scan wrapped without finding set bit */
 		eol = find_next_bit(ldata->read_flags, more, 0);
-		if (eol != more)
-			found = 1;
-	} else if (eol != size)
-		found = 1;
+		found = eol != more;
+	} else
+		found = eol != size;
 
 	n = eol - tail;
 	if (n > N_TTY_BUF_SIZE)
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] n_tty_read() helper cleanups Peter Hurley <peter@hurleysoftware.com> - 2015-11-27 20:20 +0100
  [PATCH v2 3/3] n_tty: Reduce branching in canon_copy_from_read_buf() Peter Hurley <peter@hurleysoftware.com> - 2015-11-27 20:20 +0100

csiph-web