Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event
Date	2015-11-25 18:50 +0100
Message-ID	<qyMmD-YX-13@gated-at.bofh.it> (permalink)
References	<qyKut-8c2-1@gated-at.bofh.it> <qyL7c-gt-25@gated-at.bofh.it> <qyLAe-qU-3@gated-at.bofh.it> <qyLJT-K2-1@gated-at.bofh.it> <qyLTA-O8-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 25 Nov 2015 18:12:43 +0100
Jiri Olsa <jolsa@redhat.com> wrote:

> > Yeah, I'm trying to figure out the paths here. I would love to remove
> > the control_ops as that complicates the function tracing code a bit
> > more than I would like it to be.  
> 
> perf is using the control interface to enable and disable function
> tracing any time the process (and its events) is scheduled in/out
> 
> sched_in(event)  -> ftrace_function_local_enable(&event->ftrace_ops)
> sched_out(event) -> ftrace_function_local_disable(&event->ftrace_ops)

OK, I think we can merge the control list to the normal list and have
something like:

 (!op->disabled || !ftrace_function_local_disabled(op))

We can also keep the control flag for the ops, and have:

	!(op->flags & FTRACE_OPS_FL_CONTROL) || rcu_is_watching()

test too, and use the ftrace ops list code.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ftrace: Add separate handler for ftrace:function event Jiri Olsa <jolsa@kernel.org> - 2015-11-25 16:50 +0100
  [PATCH 2/2] ftrace: Check sample types only for sampling events Jiri Olsa <jolsa@kernel.org> - 2015-11-25 16:50 +0100
  Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function  event Steven Rostedt <rostedt@goodmis.org> - 2015-11-25 17:30 +0100
    Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function  event Jiri Olsa <jolsa@redhat.com> - 2015-11-25 18:00 +0100
      Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function  event Steven Rostedt <rostedt@goodmis.org> - 2015-11-25 18:10 +0100
        Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function  event Jiri Olsa <jolsa@redhat.com> - 2015-11-25 18:20 +0100
          Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function  event Steven Rostedt <rostedt@goodmis.org> - 2015-11-25 18:50 +0100

csiph-web