Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1274995

Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs
Date 2015-11-23 00:40 +0100
Message-ID <qxMoG-2bB-23@gated-at.bofh.it> (permalink)
References <qp0TU-4iv-15@gated-at.bofh.it> <qqGHq-1jJ-41@gated-at.bofh.it> <qqJlV-2OU-25@gated-at.bofh.it> <qwSZd-79N-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2015-11-20 at 15:22 +0300, Denis Kirjanov wrote:
> On 11/3/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> > On 11/3/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > > On Thu, 2015-10-29 at 22:10 +0300, Denis Kirjanov wrote:
> > > > ./drmgr -c cpu -a -r gives the following warning:
> > > > 
> > > > [ 2327.035563] RCU used illegally from offline CPU!
> > > > 
> > > > Make the hypervisor tracepoints conditional by introducing
> > > > TRACE_EVENT_FN_COND similar to TRACE_EVENT_FN
> > > 
> > > We've fixed other cases like this with RCU_NONIDLE(), but I assume that
> > > doesn't work here because we're actually offline?
> > 
> > Yes, in this case we're moving the complete core offline through dlpar...
> > 
> 
> Hi Michael,
> Could you pick this patch?

It's mostly a tracing patch, so I'd need an ACK from Steve at least.

It would probably be best if you split it into a "tracing: .. " patch which
adds the new macros and then a powerpc patch which uses them.

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov <kda@linux-powerpc.org> - 2015-11-20 13:30 +0100
  Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs Michael Ellerman <mpe@ellerman.id.au> - 2015-11-23 00:40 +0100
    Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs Steven Rostedt <rostedt@goodmis.org> - 2015-11-23 02:00 +0100
    Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov <kda@linux-powerpc.org> - 2015-11-23 10:40 +0100

csiph-web