Re: [PATCH] fbdev: sm712fb: avoid unused function warnings

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fbdev: sm712fb: avoid unused function warnings
Date	2015-11-22 22:20 +0100
Message-ID	<qxKdc-Rx-1@gated-at.bofh.it> (permalink)
References	<qx1SP-4ve-21@gated-at.bofh.it> <qxJTQ-uu-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sunday 22 November 2015 21:51:54 Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Fri, Nov 20, 2015 at 10:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The sm712fb framebuffer driver encloses the power-management
> > functions in #ifdef CONFIG_PM, but the smtcfb_pci_suspend/resume
> > functions are only really used when CONFIG_PM_SLEEP is also
> > set, as a frequent gcc warning shows:
> >
> > fbdev/sm712fb.c:1549:12: warning: 'smtcfb_pci_suspend' defined but not used
> > fbdev/sm712fb.c:1572:12: warning: 'smtcfb_pci_resume' defined but not used
> >
> > The driver also avoids using the SIMPLE_DEV_PM_OPS macro when
> > CONFIG_PM is unset, which is redundant.
> 
> Is it? AFAIK there's no dummy of SIMPLE_DEV_PM_OPS() for the !CONFIG_PM case
> yet. May be a good idea to have, though.

The idea of the macro seems to be that the assignment of the pointers
is left out, but the structure is still there. We could fix that, but
I'd rather try to fix the macro in a way that creates an unused
reference to the functions, so we never need any #ifdef or __maybe_unused
annotation. We could also come up with a way to remove the structure
from the binary in that case, but I can't think of an obvious solution
for that at the moment.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fbdev: sm712fb: avoid unused function warnings Arnd Bergmann <arnd@arndb.de> - 2015-11-20 23:00 +0100
  Re: [PATCH] fbdev: sm712fb: avoid unused function warnings Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-22 22:00 +0100
    Re: [PATCH] fbdev: sm712fb: avoid unused function warnings Arnd Bergmann <arnd@arndb.de> - 2015-11-22 22:20 +0100

csiph-web