Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274231

Re: [PATCH v6 4/4] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

Show all headers | View raw

On Fri, 20 Nov 2015, Marek Szyprowski wrote:

> From: Ruslan Bilovol <ruslan.bilovol@gmail.com>
> 
> Change behavior during registration of gadgets and
> gadget drivers in udc-core. Instead of previous
> approach when for successful probe of usb gadget driver
> at least one usb gadget should be already registered
> use another one where gadget drivers and gadgets
> can be registered in udc-core independently.
> 
> Independent registration of gadgets and gadget drivers
> is useful for built-in into kernel gadget and gadget
> driver case - because it's possible that gadget is
> really probed only on late_init stage (due to deferred
> probe) whereas gadget driver's probe is silently failed
> on module_init stage due to no any UDC added.
> 
> Also it is useful for modules case - now there is no
> difference what module to insert first: gadget module
> or gadget driver one.
> 
> Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
> [simplified code as requested by Alan Stern and Felipe Balbi]
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

...

> @@ -475,9 +492,16 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)
>  	list_del(&udc->list);
>  	mutex_unlock(&udc_lock);
>  
> -	if (udc->driver)
> +	if (udc->driver) {
> +		struct usb_gadget_driver *driver = udc->driver;
> +
>  		usb_gadget_remove_driver(udc);
>  
> +		mutex_lock(&udc_lock);
> +		list_add(&driver->pending, &gadget_driver_pending_list);
> +		mutex_unlock(&udc_lock);
> +	}

It looks like there is a race here with usb_gadget_unregister_driver().  
Would it be okay to hold the udc_lock mutex throughout the whole "if"  
statement?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/4] usb/gadget: independent registration of gadgets and  gadget drivers Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:00 +0100
  [PATCH v6 3/4] usb: gadget: udc-core: remove unused  usb_udc_attach_driver() Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:00 +0100
  [PATCH v6 1/4] usb: gadget: bind UDC by name passed via  usb_gadget_driver structure Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:00 +0100
  [PATCH v6 2/4] usb: gadget: configfs: pass UDC name via  usb_gadget_driver struct Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:00 +0100
  [PATCH v6 4/4] usb: gadget: udc-core: independent registration of  gadgets and gadget drivers Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:00 +0100
    Re: [PATCH v6 4/4] usb: gadget: udc-core: independent registration of  gadgets and gadget drivers Marek Szyprowski <m.szyprowski@samsung.com> - 2015-11-20 10:50 +0100
      RE: [PATCH v6 4/4] usb: gadget: udc-core: independent registration of  gadgets and gadget drivers Peter Chen <Peter.Chen@freescale.com> - 2015-11-20 11:00 +0100
    Re: [PATCH v6 4/4] usb: gadget: udc-core: independent registration  of gadgets and gadget drivers Alan Stern <stern@rowland.harvard.edu> - 2015-11-20 17:30 +0100

csiph-web