Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct rounding error

From	Prarit Bhargava <prarit@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct rounding error
Date	2015-11-20 16:50 +0100
Message-ID	<qwW6K-Fa-21@gated-at.bofh.it> (permalink)
References	<qwT8S-7d6-21@gated-at.bofh.it> <qwT8S-7d6-19@gated-at.bofh.it> <qwTLA-7Gp-15@gated-at.bofh.it> <qwVDH-uA-5@gated-at.bofh.it> <qwVDH-uA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 11/20/2015 10:19 AM, Viresh Kumar wrote:
> On 20-11-15, 10:10, Prarit Bhargava wrote:
>>>>  	limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100);
>>>
>>> And put this after the later one ?
>>>
>>>> +	limits->max_policy_pct = DIV_ROUND_UP(policy->max * 100,
>>>> +					      policy->cpuinfo.max_freq);
>>>>  
>>>>  	/* Normalize user input to [min_policy_pct, max_policy_pct] */
>>>>  	limits->min_perf_pct = max(limits->min_policy_pct,
>>>
>>> Sure you tested it  ? :)
>>
>> Oops -- and yeah, tested.  It works because I rewrite the value of
>> max_policy_pct :).  I'll repost shortly.
> 
> But we aren't doing below anymore, doesn't this change the
> calculations at all?
> 
>   	limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100);

The clamp only confines the max_policy between 0 and 100.  AFAIK it doesn't make
any change tothe value of limits->max_policy_pct unless it was outside of that
range.

P.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct rounding error Prarit Bhargava <prarit@redhat.com> - 2015-11-20 13:40 +0100
  Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-20 14:20 +0100
    Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-20 16:20 +0100
      Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error Prarit Bhargava <prarit@redhat.com> - 2015-11-20 16:50 +0100
        Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2015-11-20 21:10 +0100
          Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error Prarit Bhargava <prarit@redhat.com> - 2015-11-21 00:50 +0100
            Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2015-11-21 01:00 +0100
    Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct  rounding error Prarit Bhargava <prarit@redhat.com> - 2015-11-20 16:20 +0100

csiph-web