Re: [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault()

From	David Woodhouse <dwmw2@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault()
Date	2015-11-20 16:40 +0100
Message-ID	<qwVX4-Bk-9@gated-at.bofh.it> (permalink)
References	<qvQd3-6JK-3@gated-at.bofh.it> <qvQd3-6JK-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2015-11-17 at 16:11 +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
> 
> Not doing so is a bug and might trigger a BUG_ON in
> handle_mm_fault(). So add the proper permission checks
> before calling into mm code.
> 
> Signed-off-by: Joerg Roedel <jroedel@suse.de>

Acked-By: David Woodhouse <David.Woodhouse@intel.com>

As noted, I can't test it right now until I've replaced my test
hardware. Certainly looks better than the last version though :)

Thanks.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

Thread

[PATCH 0/4 v2] Implement access checks in iommu page fault paths Joerg Roedel <joro@8bytes.org> - 2015-11-17 16:20 +0100
  [PATCH 1/4] iommu/amd: Do proper access checking before calling handle_mm_fault() Joerg Roedel <joro@8bytes.org> - 2015-11-17 16:20 +0100
  [PATCH 2/4] iommu/amd: Correctly set flags for handle_mm_fault call Joerg Roedel <joro@8bytes.org> - 2015-11-17 16:20 +0100
  [PATCH 3/4] iommu/amd: Cleanup error handling in do_fault() Joerg Roedel <joro@8bytes.org> - 2015-11-17 16:20 +0100
  [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault() Joerg Roedel <joro@8bytes.org> - 2015-11-17 16:20 +0100
    Re: [PATCH 4/4] iommu/vt-d: Do access checks before calling  handle_mm_fault() David Woodhouse <dwmw2@infradead.org> - 2015-11-20 16:40 +0100
  Re: [PATCH 0/4 v2] Implement access checks in iommu page fault paths Oded Gabbay <oded.gabbay@gmail.com> - 2015-11-18 15:10 +0100
  Re: [PATCH 0/4 v2] Implement access checks in iommu page fault paths Jesse Barnes <jbarnes@virtuousgeek.org> - 2015-11-18 17:20 +0100
    Re: [PATCH 0/4 v2] Implement access checks in iommu page fault paths Joerg Roedel <joro@8bytes.org> - 2015-11-27 13:10 +0100

csiph-web