Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273724

Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver

Show all headers | View raw

On Tue, Nov 17, 2015 at 11:35 AM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> This patch moves exynos_sys_powerdown_conf function above all
> static functions, to avoid confusion causing due to mixing of
> static-nonstatic-static functions and to improve readability of this
> driver.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/pmu.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index 01cb649..a7741d4 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -39,23 +39,6 @@ u32 pmu_raw_readl(u32 offset)
>         return readl_relaxed(pmu_base_addr + offset);
>  }
>
> -static void exynos_power_off(void)
> -{
> -       unsigned int tmp;
> -
> -       pr_info("Power down.\n");
> -       tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
> -       tmp ^= (1 << 8);
> -       pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
> -
> -       /* Wait a little so we don't give a false warning below */
> -       mdelay(100);
> -
> -       pr_err("Power down failed, please power off system manually.\n");
> -       while (1)
> -               ;
> -}
> -
>  void exynos_sys_powerdown_conf(enum sys_powerdown mode)
>  {
>         unsigned int i;
> @@ -85,6 +68,23 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode)
>         }
>  }
>
> +static void exynos_power_off(void)
> +{
> +       unsigned int tmp;
> +
> +       pr_info("Power down.\n");
> +       tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
> +       tmp ^= (1 << 8);
Can we have some define over here? to operate this bit.

> +       pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
> +
> +       /* Wait a little so we don't give a false warning below */
> +       mdelay(100);
> +
> +       pr_err("Power down failed, please power off system manually.\n");
> +       while (1)
> +               ;
> +}
> +
>  static int pmu_restart_notify(struct notifier_block *this,
>                 unsigned long code, void *unused)
>  {
> --
> 2.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/9] samsung: pmu: split up SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:10 +0100
  [PATCH v6 6/9] ARM: EXYNOS: split up exynos5250 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  Re: [PATCH v6 0/9] samsung: pmu: split up SoC specific PMU data Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 7/9] ARM: EXYNOS: split up exynos5420 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 2/9] ARM: EXYNOS: Fix potential NULL pointer access in  exynos_sys_powerdown_conf Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  Re: [PATCH v6 9/9] drivers: soc: Add support for Exynos PMU driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 9/9] drivers: soc: Add support for Exynos PMU driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 1/9] ARM: EXYNOS: removing redundant code from regs-pmu.h Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions  of PMU driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
    Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static  functions of PMU driver Manish Badarkhe <badarkhe.manish@gmail.com> - 2015-11-20 05:50 +0100
      Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static  functions of PMU driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-20 06:20 +0100
  [PATCH v6 4/9] ARM: EXYNOS: split up exynos3250 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 5/9] ARM: EXYNOS: split up exynos4 SoC specific PMU data Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100
  [PATCH v6 3/9] ARM: EXYNOS: Move pmu specific headers under  "linux/soc/samsung" Pankaj Dubey <pankaj.dubey@samsung.com> - 2015-11-17 07:20 +0100

csiph-web