Re: [PATCH v5 2/9] perf callchain: Abstract callchain print function

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/9] perf callchain: Abstract callchain print function
Date	2015-11-20 02:40 +0100
Message-ID	<qwIQ9-sf-3@gated-at.bofh.it> (permalink)
References	<qsNv3-2fT-3@gated-at.bofh.it> <qsNv4-2fT-9@gated-at.bofh.it> <qwxL4-1xA-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnaldo,

On Thu, Nov 19, 2015 at 10:41:32AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 09, 2015 at 02:45:39PM +0900, Namhyung Kim escreveu:
> > This is a preparation to support for printing other type of callchain
> > value like count or period.
> > 
> > Acked-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---

[SNIP]
> > +char *callchain_node__sprintf_value(struct callchain_node *node,
> > +				    char *bf, size_t bfsize, u64 total)
> 
>  sprintf doesn't require a bfsize, snprintf does, but we don't use that,
> so renaming it to callchain_node__scnprintf_value() so that we recall
> the semantic associated with this operation.

OK, and thank you for doing this!

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/9] perf callchain: Abstract callchain print function Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-19 14:50 +0100
  Re: [PATCH v5 2/9] perf callchain: Abstract callchain print function Namhyung Kim <namhyung@kernel.org> - 2015-11-20 02:40 +0100

csiph-web