Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx
Date	2015-11-18 00:00 +0100
Message-ID	<qvXoe-2MS-3@gated-at.bofh.it> (permalink)
References	<qvQmJ-6NX-7@gated-at.bofh.it> <qvQmK-6NX-27@gated-at.bofh.it> <qvSyf-8a9-25@gated-at.bofh.it> <qvU70-N7-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Nov 17, 2015 at 11:21:12AM -0800, Joshua Clayton wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> It takes some clutter out of main() whose scope is limited to that little block of code, 
> and because in the next patch we add another (larger)function to the if/else block.

> I don't know if it is valid to say "look at the next commit" for justification, but
> That is the reason.

That's totally fine - just say that it's to support future changes in
this area.  It's good to split out mechanical changes like this from the
more complex changes, you just need to say why they're happening.

Thread

[PATCH 0/8] spi: Add file i/o to spidev_test Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
  [PATCH 8/8] spi: Move spi code from Documentation to tools Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
    Re: [PATCH 8/8] spi: Move spi code from Documentation to tools Mark Brown <broonie@kernel.org> - 2015-11-17 19:20 +0100
  [PATCH 5/8] Documentation/spi/spidev_test.c: check error Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
  [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a file Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
    Re: [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a  file Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-17 19:30 +0100
      Re: [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a  file Mark Brown <broonie@kernel.org> - 2015-11-17 19:50 +0100
      Re: [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a file Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 20:30 +0100
  [PATCH 7/8] tools/Makefile: minor whitespace cleanup Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
    Re: [PATCH 7/8] tools/Makefile: minor whitespace cleanup Mark Brown <broonie@kernel.org> - 2015-11-17 19:10 +0100
      Re: [PATCH 7/8] tools/Makefile: minor whitespace cleanup Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 20:50 +0100
  [PATCH 6/8] Documentation/spi/spidev_test.c: fix whitespace Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
  [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
    Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Mark Brown <broonie@kernel.org> - 2015-11-17 18:50 +0100
      Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 20:30 +0100
        Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Mark Brown <broonie@kernel.org> - 2015-11-18 00:00 +0100
  Re: [PATCH 0/8] spi: Add file i/o to spidev_test Mark Brown <broonie@kernel.org> - 2015-11-17 16:40 +0100
    Re: [PATCH 0/8] spi: Add file i/o to spidev_test Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 17:20 +0100
      Re: [PATCH 0/8] spi: Add file i/o to spidev_test Mark Brown <broonie@kernel.org> - 2015-11-17 18:00 +0100
      [PATCH v2 0/6] spi: Add file i/o to spidev_test Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100
        [PATCH v2 1/6] spi: Move spi code from Documentation to tools Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100
        [PATCH v2 6/6] spi: spidev_test: fix whitespace Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100
        [PATCH v2 5/6] spi: spidev_test: check error Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100
        [PATCH v2 2/6] spi: spidev_test: transfer_escaped_string function Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100
        [PATCH v2 4/6] spi: spidev_test: output to a file Joshua Clayton <stillcompiling@gmail.com> - 2015-11-18 23:40 +0100

csiph-web