Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271334

[PATCH] xen/events: Always allocate legacy interrupts on PV guests

Show all headers | View raw

After commit 8c058b0b9c34 ("x86/irq: Probe for PIC presence before
allocating descs for legacy IRQs") early_irq_init() will no longer
preallocate descriptors for legacy interrupts if PIT does not
exist.

Therefore we need to allocate those descriptors for PV guests
ourselves.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/xen/events/events_base.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 849500e..a2bb333 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -419,8 +419,8 @@ static int __must_check xen_allocate_irq_gsi(unsigned gsi)
 	if (xen_pv_domain() && !xen_initial_domain())
 		return xen_allocate_irq_dynamic();
 
-	/* Legacy IRQ descriptors are already allocated by the arch. */
-	if (gsi < NR_IRQS_LEGACY)
+	/* On HVM legacy IRQ descriptors are already allocated by the arch. */
+	if (xen_hvm_domain() && gsi < NR_IRQS_LEGACY)
 		irq = gsi;
 	else
 		irq = irq_alloc_desc_at(gsi, -1);
@@ -445,8 +445,8 @@ static void xen_free_irq(unsigned irq)
 
 	kfree(info);
 
-	/* Legacy IRQ descriptors are managed by the arch. */
-	if (irq < NR_IRQS_LEGACY)
+	/* On HVM legacy IRQ descriptors are managed by the arch. */
+	if (xen_hvm_domain() && irq < NR_IRQS_LEGACY)
 		return;
 
 	irq_free_desc(irq);
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen/events: Always allocate legacy interrupts on PV guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-17 16:40 +0100
  Re: [PATCH] xen/events: Always allocate legacy interrupts on PV  guests Juergen Gross <jgross@suse.com> - 2015-11-17 17:30 +0100
  Re: [Xen-devel] [PATCH] xen/events: Always allocate legacy interrupts on PV guests Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-18 12:20 +0100
    Re: [Xen-devel] [PATCH] xen/events: Always allocate legacy interrupts  on PV guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-18 15:10 +0100
      Re: [Xen-devel] [PATCH] xen/events: Always allocate legacy interrupts on PV guests Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-18 15:30 +0100
        Re: [Xen-devel] [PATCH] xen/events: Always allocate legacy interrupts  on PV guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-18 16:10 +0100

csiph-web