Re: net-ipv6: Delete unnecessary checks before the function call "kfree_skb"

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: net-ipv6: Delete unnecessary checks before the function call "kfree_skb"
Date	2015-11-15 07:20 +0100
Message-ID	<quYPn-69L-1@gated-at.bofh.it> (permalink)
References	(14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <quOn0-7Yp-19@gated-at.bofh.it> <quWky-4ua-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> While if the test is done in kfree_skb(), the branch predictor of the
> cpu wont be able to predict things.
> 
> By feeding too many NULL pointers to kfree_skb(), we slow down it.

Would it make sense to annotate checks before such function calls
as "UNLIKELY"?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net-ipv6: Delete unnecessary checks before the function call  "kfree_skb" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-14 20:10 +0100
  Re: [PATCH] net-ipv6: Delete unnecessary checks before the function  call "kfree_skb" Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-15 04:40 +0100
    Re: net-ipv6: Delete unnecessary checks before the function call  "kfree_skb" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-15 07:20 +0100

csiph-web