Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

From	Jerry Hoemann <jerry.hoemann@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru
Date	2015-11-11 02:50 +0100
Message-ID	<qtsHT-4yD-5@gated-at.bofh.it> (permalink)
References	<qrXG9-29C-5@gated-at.bofh.it> <qrXG9-29C-5@gated-at.bofh.it> <qrXG9-29C-3@gated-at.bofh.it> <qtp7k-2b1-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote:
> Jerry Hoemann <jerry.hoemann@hpe.com> writes:
> 
> > +	uuid = pkg->h.dsm_uuid;
> > +	rev  = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1;
> 
> Shouldn't revision id be required?
> 

Yes it should be.  Good catch.

I was testing use of reclaiming previously unused members of
the structure.  I should have removed this line.

And this reminds me that I should also add a test that the reserved fields
of ndn_pkg are actually zero.

I'll address both in version 2.

thanks

-- 

-----------------------------------------------------------------------------
Jerry Hoemann            Software Engineer      Hewlett-Packard Enterprise
-----------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-06 23:30 +0100
  Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 17:30 +0100
    Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-10 22:40 +0100
      Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 22:50 +0100
        Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-10 23:20 +0100
  Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jeff Moyer <jmoyer@redhat.com> - 2015-11-10 23:00 +0100
    Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-11-11 02:50 +0100

csiph-web