Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments

From	Lukasz Pawelczyk <l.pawelczyk@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr arguments
Date	2015-11-10 11:20 +0100
Message-ID	<qtebU-3Kn-13@gated-at.bofh.it> (permalink)
References	<qjtFf-7cv-21@gated-at.bofh.it> <qjtOW-7od-19@gated-at.bofh.it> <qt8zv-7V-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote:
> On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote:
> >  	int (*getprocattr)(struct task_struct *p, char *name, char
> > **value);
> > -	int (*setprocattr)(struct task_struct *p, char *name, void
> > *value,
> > -				size_t size);
> > +	int (*setprocattr)(struct task_struct *p, const struct
> > cred *f_cred,
> > +			   char *name, void *value, size_t size);
> 
> *grumble*
> 
> Why the hell is that thing taking char *name - not even const char *?

I was wondering that myself. But as this is unrelated I decided not to
change it. Do you want me to while at it?




-- 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr  arguments Al Viro <viro@ZenIV.linux.org.uk> - 2015-11-10 05:20 +0100
  Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr  arguments Lukasz Pawelczyk <l.pawelczyk@samsung.com> - 2015-11-10 11:20 +0100

csiph-web