Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser data
Date	2015-11-12 00:50 +0100
Message-ID	<qtNjj-19f-7@gated-at.bofh.it> (permalink)
References	<qpvbj-69C-5@gated-at.bofh.it> <qpvbj-69C-7@gated-at.bofh.it> <qq9s6-5Gg-15@gated-at.bofh.it> <qquwz-1Uo-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 02, 2015 at 01:00:01PM -0800, Brian Norris wrote:
> On Sun, Nov 01, 2015 at 11:32:37PM +0100, Boris Brezillon wrote:
> > On Fri, 30 Oct 2015 20:33:25 -0700
> > Brian Norris <computersforpeace@gmail.com> wrote:
> > 
> [...]
> > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
> > > index dcb1f7f4873f..850546dc98c8 100644
> > > --- a/drivers/mtd/nand/fsl_elbc_nand.c
> > > +++ b/drivers/mtd/nand/fsl_elbc_nand.c
> > > @@ -748,6 +748,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
> > >  	/* Fill in fsl_elbc_mtd structure */
> > >  	priv->mtd.priv = chip;
> > >  	priv->mtd.dev.parent = priv->dev;
> > > +	chip->flash_node = priv->dev->of_node;
> > 
> > Shouldn't we use the nand_set_flash_node() helper here? Here is a diff replacing
> > all 'chip->flash_node =' occurrences by nand_set_flash_node():
> 
> Hmm, I don't know why I overlooked those. I think maybe I did the
> initial replacement before this patch and forgot to do the same
> replacement on my subsequent work. I guess that's what happens when I
> rebase/rework too much...
> 
> Thanks for the diff. I'll probably squash it into v3 if/when that comes.

Pushed my patch 6 + your diff to l2-mtd.git/next. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser  data Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-01 23:40 +0100
  Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser  data Brian Norris <computersforpeace@gmail.com> - 2015-11-02 22:10 +0100
    Re: [PATCH v2 06/11] mtd: nand: drop unnecessary partition parser  data Brian Norris <computersforpeace@gmail.com> - 2015-11-12 00:50 +0100

csiph-web