Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264978

[PATCH 02/12] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function

Show all headers | View raw

Ideally the function should not change the variables outside of its body.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
 drivers/staging/rtl8188eu/hal/fw.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
index 4d72537..5b569ef 100644
--- a/drivers/staging/rtl8188eu/hal/fw.c
+++ b/drivers/staging/rtl8188eu/hal/fw.c
@@ -75,14 +75,14 @@ static void _rtl88e_fw_block_write(struct adapter *adapt,
 		usb_write8(adapt, write_address, byte_buffer[i]);
 }
 
-static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen)
+static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
 {
 	u32 i;
 
-	for (i = *pfwlen; i < roundup(*pfwlen, 4); i++)
+	for (i = pfwlen; i < roundup(pfwlen, 4); i++)
 		pfwbuf[i] = 0;
 
-	*pfwlen = i;
+	return i;
 }
 
 static void _rtl88e_fw_page_write(struct adapter *adapt,
@@ -103,7 +103,7 @@ static void _rtl88e_write_fw(struct adapter *adapt, u8 *buffer, u32 size)
 	u32 page_no, remain;
 	u32 page, offset;
 
-	_rtl88e_fill_dummy(buf_ptr, &size);
+	size = _rtl88e_fill_dummy(buf_ptr, size);
 
 	page_no = size / FW_8192C_PAGE_SIZE;
 	remain = size % FW_8192C_PAGE_SIZE;
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 02/12] staging: rtl8188eu: return value and argument types  changed in _rtl88e_write_fw function Ivan Safonov <insafonov@gmail.com> - 2015-11-08 08:00 +0100
  Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types  changed in _rtl88e_write_fw function Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 11:20 +0100
    Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types  changed in _rtl88e_write_fw function Ivan Safonov <insafonov@gmail.com> - 2015-11-08 12:30 +0100
      Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types  changed in _rtl88e_write_fw function Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 21:30 +0100
        Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types  changed in _rtl88e_write_fw function Ivan Safonov <insafonov@gmail.com> - 2015-11-10 10:30 +0100

csiph-web