Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265757

Re: Grafting old platform drivers onto a new DT kernel

Show all headers | View raw

On 05/11/2015 16:42, Javier Martinez Canillas wrote:
> Hello,
> 
> On Thu, Nov 5, 2015 at 12:15 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>>> Since I don't have time to rewrite the drivers at the moment, I'm wondering
>>> if it's possible to "graft" old drivers (they're using the platform API, no
>>> trace of DT support) onto my small base?
>>
>> Platform drivers are still usable with DT systems. We used that fact
>> when converting platform based machines over to DT, one driver at a
>> time. Look in the git history for kirkwood devices. e.g. somewhere
>> around v3.7, arch/arm/mach-kirkwood. board-dt.c, and the various
>> board-*.c files, and the DT files in the usual place.
>>
> 
> OMAP did the same and still some boards use platform data and manually
> register platform devices from board code. Take a look to
> arch/arm/mach-omap2/pdata-quirks.c to see how that is being done.

Hello,

I tried compiling an ancient SDHCI driver on a v4.2 system. It crashes
all over init because several host->ops functions are required, but the
old driver does not define them:
.reset
.set_clock
.set_bus_width
.set_uhs_signaling

So I downgraded to an older v3.14 kernel, and that problem vanished.
But I am having a problem with the IRQ setup.

# cat /proc/interrupts 
            CPU0       CPU1       
 18:         93          0      irq0   1 Level     serial
 55:       2832          0      irq0  38 Level     26000.ethernet
 60:          0          0      irq0  43 Edge      mmc0
211:        319       2603       GIC  29 Edge      twd

Ethernet is using IRQ 38, as specified in the DT.
mmc0 is supposed to use IRQ 60.

I see that the mmc0 has the index 60, so I must have messed up between
the real irq (hwirq?) and the index Linux uses internally (virq?)

static struct resource sdhci_resources[] = {
	{
		.start	= TANGOX_SDIO0_BASE_ADDR,
		.end	= TANGOX_SDIO0_BASE_ADDR + 0x1ff,
		.flags	= IORESOURCE_MEM,
	},
	{
		.start	= 60,	/* SDHCI0 IRQ */
		.flags	= IORESOURCE_IRQ,
	},
};

Both ethernet and sdhci driver call platform_get_irq(pdev, 0);
but the eth driver is DT, so calls of_irq_get() while sdhci is
legacy, so calls platform_get_resource() -- IIUC.

How do I specify a "hwirq" instead of a "Linux index"? and where?

Is this relevant?
https://www.kernel.org/doc/Documentation/IRQ-domain.txt

Should I use irq_linear_revmap() / irq_find_mapping() ?

Regards.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Grafting old platform drivers onto a new DT kernel Mason <slash.tmp@free.fr> - 2015-11-05 12:10 +0100
  Re: Grafting old platform drivers onto a new DT kernel Andrew Lunn <andrew@lunn.ch> - 2015-11-05 16:20 +0100
    Re: Grafting old platform drivers onto a new DT kernel Javier Martinez Canillas <javier@dowhile0.org> - 2015-11-05 16:50 +0100
      Re: Grafting old platform drivers onto a new DT kernel Mason <slash.tmp@free.fr> - 2015-11-09 16:20 +0100
        Re: Grafting old platform drivers onto a new DT kernel Marc Zyngier <marc.zyngier@arm.com> - 2015-11-09 16:40 +0100
        Re: Grafting old platform drivers onto a new DT kernel Måns Rullgård <mans@mansr.com> - 2015-11-09 16:50 +0100
          Re: Grafting old platform drivers onto a new DT kernel Mason <slash.tmp@free.fr> - 2015-11-09 17:10 +0100
            Re: Grafting old platform drivers onto a new DT kernel Måns Rullgård <mans@mansr.com> - 2015-11-09 17:20 +0100
              Re: Grafting old platform drivers onto a new DT kernel Mason <slash.tmp@free.fr> - 2015-11-09 18:10 +0100
                Re: Grafting old platform drivers onto a new DT kernel Måns Rullgård <mans@mansr.com> - 2015-11-09 18:20 +0100
                Re: Grafting old platform drivers onto a new DT kernel Mason <slash.tmp@free.fr> - 2015-11-10 13:50 +0100
                Re: Grafting old platform drivers onto a new DT kernel Arnd Bergmann <arnd@arndb.de> - 2015-11-10 14:00 +0100
        Re: Grafting old platform drivers onto a new DT kernel Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-09 17:30 +0100

csiph-web