Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265210

Re: [PATCH] dma: fix returnvar.cocci warnings

Show all headers | View raw

On 11/08/2015 07:45 AM, Julia Lawall wrote:
>  Remove unneeded variable used to store return value.
> 
> --- a/drivers/dma/qcom/hidma_ll.c
> +++ b/drivers/dma/qcom/hidma_ll.c
> @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev *
> 
>  static int hidma_ll_hw_start(struct hidma_lldev *lldev)
>  {
> -	int rc = 0;
>  	unsigned long irqflags;
> 
>  	spin_lock_irqsave(&lldev->lock, irqflags);
>  	writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET);
>  	spin_unlock_irqrestore(&lldev->lock, irqflags);
> 
> -	return rc;
> +	return 0;
>  }
> 
>  bool hidma_ll_isenabled(struct hidma_lldev *lldev)

Seems rather pointless, what about 'static void ...' and dropping the
return statement?


Daniel K.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] dma: fix returnvar.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-11-08 08:50 +0100
  Re: [PATCH] dma: fix returnvar.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-11-08 22:20 +0100
  Re: [PATCH] dma: fix returnvar.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-11-08 22:20 +0100
  Re: [PATCH] dma: fix returnvar.cocci warnings Timur Tabi <timur@codeaurora.org> - 2015-11-08 22:20 +0100
  Re: [PATCH] dma: fix returnvar.cocci warnings Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 22:20 +0100
  Re: [PATCH] dma: fix returnvar.cocci warnings "Daniel K." <dk@syse.no> - 2015-11-08 23:00 +0100
    Re: [PATCH] dma: fix returnvar.cocci warnings Sinan Kaya <okaya@codeaurora.org> - 2015-11-08 23:10 +0100

csiph-web