Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage
Date	2015-11-05 13:20 +0100
Message-ID	<qrrGi-6Az-23@gated-at.bofh.it> (permalink)
References	<qk8yK-FP-7@gated-at.bofh.it> <qr1LQ-6u1-15@gated-at.bofh.it> <qr9zH-2YD-13@gated-at.bofh.it> <qrhQC-8ni-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 05, 2015 at 03:15:18AM +0100, Rafael J. Wysocki wrote:

> > > + Rafael
> > >
> > > This is contrariry to what I see, If my driver is runtime suspended and on
> > > suspend, it gets runtime resumed and then suspended
> > 
> > Since I was late to the thread, can you explain what kind of driver and
> > on what bus type you're seeing this behavior?
> > 
> > It could be that your bus-type is doing something, but I don't think it
> > should be the PM core.
> 
> Right.
> 
> Bus types do that, the core doesn't.  The ACPI PM domain does that too
> for some devices.
> 
> So Vinod, more details, please.

Okay relooking at core I do think that runtime resume should not be invoked
while suspending, as core seems to call pm_runtime_get_noresume() but I am
still missing something here..

I do see this behaviour (runtime resume on suspend) on Intel audio drivers
which are PCI devices, is PCI or ACPI doing some magic here.

I have seen this as consistent behavior and actually an irritant, as we used
to download firmware in resume patch, but then we end up thrashing the
controller while going to suspend!

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Jon Hunter <jonathanh@nvidia.com> - 2015-11-03 17:30 +0100
  Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Kevin Hilman <khilman@kernel.org> - 2015-11-03 22:30 +0100
    Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Vinod Koul <vinod.koul@intel.com> - 2015-11-04 09:40 +0100
      Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Kevin Hilman <khilman@kernel.org> - 2015-11-04 18:00 +0100
        Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-05 02:50 +0100
          Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Vinod Koul <vinod.koul@intel.com> - 2015-11-05 13:20 +0100

csiph-web