Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex
Date	2015-11-05 09:50 +0100
Message-ID	<qrop3-4fa-1@gated-at.bofh.it> (permalink)
References	<qpgvE-5lJ-5@gated-at.bofh.it> <qpllD-5l-5@gated-at.bofh.it> <qptVU-5mo-7@gated-at.bofh.it> <qqsO5-JS-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02-11-15, 11:14, Stephen Boyd wrote:
> On 10/31, Viresh Kumar wrote:
> > I don't know what is wrong (or right) with my exynos 5250 board, but I
> > didn't got any splat here even with the right config options (yes I
> > should have mentioned that earlier). I have seen this at other times
> > as well, while we were running after some cpufreq traces..
> > 
> > But, the case in hand is pretty straight forward and Mike T. did get a
> > splat as that's what he told me. We are calling a sleep-able function
> > from rcu_lock and that's obviously wrong.
> 
> That's slightly concerning. Given that the bug is so straight
> forward but we can't reproduce it doesn't instill a lot of
> confidence that the patch is correct.

Good that I spent some time debugging why I wasn't able to hit the
lockdep. And that's because by default CONFIG_PREEMPT_RCU was
selected on exynos and so the dummy function was getting enabled, and
so no WARN.

#if defined(CONFIG_PROVE_RCU) && !defined(CONFIG_PREEMPT_RCU)
static inline void rcu_preempt_sleep_check(void)
{
	RCU_LOCKDEP_WARN(lock_is_held(&rcu_lock_map),
			 "Illegal context switch in RCU read-side critical section");
}
#else /* #ifdef CONFIG_PROVE_RCU */
static inline void rcu_preempt_sleep_check(void)
{
}
#endif /* #else #ifdef CONFIG_PROVE_RCU */

Whereas for omap, that's not the case :)

So, with some config changes, I was able to hit the lockdep :)

And just to confirm, they got fixed by the $Subject patch :)

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Stephen Boyd <sboyd@codeaurora.org> - 2015-11-02 20:20 +0100
  Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-04 03:20 +0100
  Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-05 09:50 +0100

csiph-web