Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260313
| From | Neil Brown <nfbrown@novell.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing |
| Date | 2015-11-02 04:10 +0100 |
| Message-ID | <qqdFn-8qw-3@gated-at.bofh.it> (permalink) |
| References | <qpie5-6qe-3@gated-at.bofh.it> <qpie5-6qe-1@gated-at.bofh.it> <qpAb0-EJ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Sat, Oct 31 2015, Oliver Neukum wrote: > On Fri, 2015-10-30 at 14:47 +0100, Jiri Kosina wrote: >> Basically the main argument why kthread freezer is not needed boils >> down to >> this: the only facility that is needed during suspend: "no persistent >> fs >> changes are allowed from now on". > > Is that true? Drivers of character devices also may assume > that IO and suspend() wouldn't race (except in fairly clear exceptions) Anything that is a device can hook in to the suspend using the standard call back and make sure no problematic races happen. Filesystems are different partly because the "know" in memory some details of what is persisting on storage, and partly because they aren't devices. Maybe filesystems should be devices .... though that probably wouldn't help much. I would suggest that "the only facility that is needed during suspend" is really "well defined states and well defined transitions". Filesystems need them as well as devices, and frozen kthreads might have been a kludge to try to provide them. NeilBrown
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing Jiri Kosina <jikos@kernel.org> - 2015-10-30 14:50 +0100
Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing kbuild test robot <lkp@intel.com> - 2015-10-30 15:10 +0100
Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing Oliver Neukum <oneukum@suse.com> - 2015-10-31 10:00 +0100
Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing Neil Brown <nfbrown@novell.com> - 2015-11-02 04:10 +0100
Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing yalin wang <yalin.wang2010@gmail.com> - 2015-11-02 09:00 +0100
Re: [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing Jiri Kosina <jikos@kernel.org> - 2015-11-02 12:10 +0100
csiph-web