Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260157
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master |
| Date | 2015-11-01 14:20 +0100 |
| Message-ID | <qq0I9-l7-3@gated-at.bofh.it> (permalink) |
| References | <qpIie-5IS-15@gated-at.bofh.it> <qpIie-5IS-13@gated-at.bofh.it> <qpUCJ-4St-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Wolfram Sang <wsa@the-dreams.de> writes: > On Sat, Oct 31, 2015 at 05:35:57PM +0000, Mans Rullgard wrote: >> This adds a driver for the Sigma Designs SMP8642 built-in I2C master >> controller. The hardware is very similar to the I2C controller in the >> Ralink RT3050 chip with the addition of interrupt generation and an >> inverted busy/idle status bit. There are typically two controllers with >> a shared IRQ. >> >> Signed-off-by: Mans Rullgard <mans@mansr.com> > > Thanks for the driver. Same answer as here, though: > > http://www.spinics.net/lists/linux-i2c/msg17001.html > >> +#define TANGOX_I2C_CONFIG 0x00 >> +#define TANGOX_I2C_CLKDIV 0x04 >> +#define TANGOX_I2C_DEVADDR 0x08 >> +#define TANGOX_I2C_ADDR 0x0c >> +#define TANGOX_I2C_DATAOUT 0x10 >> +#define TANGOX_I2C_DATAIN 0x14 >> +#define TANGOX_I2C_STATUS 0x18 >> +#define TANGOX_I2C_STARTXFER 0x1c >> +#define TANGOX_I2C_BYTECNT 0x20 >> +#define TANGOX_I2C_INT_EN 0x24 >> +#define TANGOX_I2C_INT_STAT 0x28 > > The register set looks like the one from i2c-xlr.c, only that they are > 32 bit apart instead of 8. Can you check if you can reuse that driver? It does look very similar indeed. I thought I'd checked for an existing driver, but apparently I missed that one. I'll modify the xlr driver to handle this hardware as well instead. -- Måns Rullgård mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] devicetree: i2c: add binding for Sigma Designs SMP8642 I2C master Mans Rullgard <mans@mansr.com> - 2015-10-31 18:40 +0100
[PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master Mans Rullgard <mans@mansr.com> - 2015-10-31 18:40 +0100
Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master Wolfram Sang <wsa@the-dreams.de> - 2015-11-01 07:50 +0100
Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master Måns Rullgård <mans@mansr.com> - 2015-11-01 14:20 +0100
Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master Wolfram Sang <wsa@the-dreams.de> - 2015-11-01 16:40 +0100
Re: [PATCH 1/2] devicetree: i2c: add binding for Sigma Designs SMP8642 I2C master Rob Herring <robh+dt@kernel.org> - 2015-10-31 19:40 +0100
csiph-web