Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259811

Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size

From Keith Busch <keith.busch@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size
Date 2015-10-30 22:50 +0100
Message-ID <qppIC-2BU-11@gated-at.bofh.it> (permalink)
References (4 earlier) <qozqG-3k6-21@gated-at.bofh.it> <qoU26-89o-11@gated-at.bofh.it> <qoXMn-26W-25@gated-at.bofh.it> <qoZbt-386-21@gated-at.bofh.it> <qppyW-2yK-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Oct 30, 2015 at 02:35:11PM -0700, Nishanth Aravamudan wrote:
> Given that it's 4K just about everywhere by default (and sort of
> implicitly expected to be, I guess), I think I'd prefer we default to
> 4K. That should mitigate the performance impact (I'll ask our IO team to
> do some runs, but since this impacts functionality on some hardware, I
> don't think it's too relevant for now). Unless there are NVMe devcies
> with a MPSMAX < 4K? 

Right, I assumed MPSMIN was always 4k for the same reason you mentioned,
but you can hard code it like you've done in your patch.

The spec defines MPSMAX such that it's impossible to find a device
with MPSMAX < 4k.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:00 +0200
  Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:00 +0200
  [PATCH 1/7 v3] dma-mapping: add generic dma_get_page_shift API Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:00 +0200
  [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:00 +0200
    Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-10-27 07:10 +0100
      Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift "Busch, Keith" <keith.busch@intel.com> - 2015-10-27 15:10 +0100
      Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-27 23:30 +0100
        Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-10-28 02:10 +0100
          Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-28 03:00 +0100
            Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2015-10-28 03:30 +0100
              Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-28 03:40 +0100
                Re: [PATCH 2/7 v2] powerpc/dma-mapping: override dma_get_page_shift Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2015-10-28 04:30 +0100
  [PATCH 4/7 v2] pseries/iommu: implement DDW-aware dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:00 +0200
    Re: [PATCH 4/7 v2] pseries/iommu: implement DDW-aware  dma_get_page_shift Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-10-27 07:00 +0100
      Re: [PATCH 4/7 v2] pseries/iommu: implement DDW-aware  dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-27 23:30 +0100
  [RFC PATCH 6/7] sparc/dma-mapping: override dma_get_page_shift Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:10 +0200
  [PATCH 7/7 v2] drivers/nvme: default to the IOMMU page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:10 +0200
  [PATCH 5/7] [RFC PATCH 5/7] sparc: rename kernel/iommu_common.h ->  include/asm/iommu_common.h Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:10 +0200
    Re: [PATCH 5/7] [RFC PATCH 5/7] sparc: rename kernel/iommu_common.h  -> include/asm/iommu_common.h Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-23 23:10 +0200
  Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA David Miller <davem@davemloft.net> - 2015-10-27 02:20 +0100
    Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-27 23:30 +0100
      Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA "Busch, Keith" <keith.busch@intel.com> - 2015-10-27 23:40 +0100
        Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA David Miller <davem@davemloft.net> - 2015-10-28 01:40 +0100
          Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA "Busch, Keith" <keith.busch@intel.com> - 2015-10-28 15:00 +0100
            Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Christoph Hellwig <hch@infradead.org> - 2015-10-29 13:00 +0100
              Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-29 17:00 +0100
                Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA "Busch, Keith" <keith.busch@intel.com> - 2015-10-29 18:30 +0100
                [PATCH 1/1 v3] drivers/nvme: default to 4k device page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-30 22:40 +0100
                Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size Keith Busch <keith.busch@intel.com> - 2015-10-30 22:50 +0100
                Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-30 23:20 +0100
                Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size Christoph Hellwig <hch@infradead.org> - 2015-11-03 14:20 +0100
                Re: [PATCH 1/1 v3] drivers/nvme: default to 4k device page size Keith Busch <keith.busch@intel.com> - 2015-11-03 14:50 +0100
                [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-11-05 18:10 +0100
                Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Christoph Hellwig <hch@infradead.org> - 2015-11-05 21:00 +0100
                Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-11-05 23:00 +0100
                Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-11-06 17:20 +0100
                Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Christoph Hellwig <hch@infradead.org> - 2015-11-13 08:40 +0100
                Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size Keith Busch <keith.busch@intel.com> - 2015-11-13 16:10 +0100
                Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA David Miller <davem@davemloft.net> - 2015-10-30 02:40 +0100
                Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-30 22:40 +0100
      Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Julian Calaby <julian.calaby@gmail.com> - 2015-10-28 00:00 +0100
        Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Julian Calaby <julian.calaby@gmail.com> - 2015-10-28 00:50 +0100
          Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2015-10-28 01:40 +0100
          Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA David Miller <davem@davemloft.net> - 2015-10-28 01:50 +0100
        Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-28 00:50 +0100
      Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA David Miller <davem@davemloft.net> - 2015-10-28 01:40 +0100
        Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA Nishanth Aravamudan <nacc@linux.vnet.ibm.com> - 2015-10-28 03:00 +0100

csiph-web