Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259472

[PATCH] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus()

Show all headers | View raw

We are returning 0 even in case of errors, fix it.

Fixes: 8d4d4e98acd6 ("PM / OPP: Add helpers for initializing CPU OPPs")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/base/power/opp/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
index 91f15b2e25ee..2122543e769d 100644
--- a/drivers/base/power/opp/cpu.c
+++ b/drivers/base/power/opp/cpu.c
@@ -153,7 +153,7 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
 unlock:
 	mutex_unlock(&dev_opp_list_lock);
 
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(dev_pm_opp_set_sharing_cpus);
 
-- 
2.6.2.198.g614a2ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM / OPP: Protect updates to list_dev with mutex Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-30 13:00 +0100
  Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-30 13:10 +0100
    [PATCH] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus() Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-30 13:50 +0100
      Re: [PATCH] PM / OPP: Propagate error properly from  dev_pm_opp_set_sharing_cpus() Stephen Boyd <sboyd@codeaurora.org> - 2015-10-30 22:00 +0100
  Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Stephen Boyd <sboyd@codeaurora.org> - 2015-10-30 18:10 +0100
    Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-31 03:20 +0100

csiph-web