Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host

From	Hannes Reinecke <hare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host
Date	2015-10-30 13:00 +0100
Message-ID	<qpgvE-5lJ-9@gated-at.bofh.it> (permalink)
References	<qpglX-5iu-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/30/2015 12:40 PM, Vitaly Kuznetsov wrote:
> Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the
> SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at
> least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan:
> INQUIRY result too short (5), using 36' messages on console. This can be
> problematic for slow consoles. Introduce short_inquiry flag in struct
> Scsi_Host to print the message once per host.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> Changes since v3 RESEND:
> - Sorry, I screwed up James address when sending 'v3 RESEND'.
> 
> Changes since v3:
> - no changes, this is just a RESEND.
> 
> Changes since v2:
> - This is a successor of previously sent (and still not merged) "scsi:
>   introduce short_inquiry flag for broken host adapters" patch. I'm not
>   particularly sure which solution is better but I'm leaning towards this
>   one as it doesn't require changes to adapter drivers.
> ---
>  drivers/scsi/scsi_scan.c | 9 ++++++---
>  include/scsi/scsi_host.h | 3 +++
>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
Why not printk_once?
Should achieve the same result, and we're saving yet another flag...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-10-30 12:50 +0100
  Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once  per host Hannes Reinecke <hare@suse.de> - 2015-10-30 13:00 +0100
    Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-10-30 14:00 +0100

csiph-web