Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256493
| From | Chaotian Jing <chaotian.jing@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 03/10] mmc: mediatek: make cmd_ints_mask to const |
| Date | 2015-10-27 07:30 +0100 |
| Message-ID | <qo5VE-1MC-27@gated-at.bofh.it> (permalink) |
| References | <qo5VE-1MC-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
cmd_ints_mask and data_ints_mask are constant value,
so make it to const
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index b2e89d3..8b3e15d 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -353,7 +353,10 @@ static void msdc_reset_hw(struct msdc_host *host)
static void msdc_cmd_next(struct msdc_host *host,
struct mmc_request *mrq, struct mmc_command *cmd);
-static u32 data_ints_mask = MSDC_INTEN_XFER_COMPL | MSDC_INTEN_DATTMO |
+static const u32 cmd_ints_mask = MSDC_INTEN_CMDRDY | MSDC_INTEN_RSPCRCERR |
+ MSDC_INTEN_CMDTMO | MSDC_INTEN_ACMDRDY |
+ MSDC_INTEN_ACMDCRCERR | MSDC_INTEN_ACMDTMO;
+static const u32 data_ints_mask = MSDC_INTEN_XFER_COMPL | MSDC_INTEN_DATTMO |
MSDC_INTEN_DATCRCERR | MSDC_INTEN_DMA_BDCSERR |
MSDC_INTEN_DMA_GPDCSERR | MSDC_INTEN_DMA_PROTECT;
@@ -725,10 +728,7 @@ static bool msdc_cmd_done(struct msdc_host *host, int events,
if (done)
return true;
- sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_CMDRDY |
- MSDC_INTEN_RSPCRCERR | MSDC_INTEN_CMDTMO |
- MSDC_INTEN_ACMDRDY | MSDC_INTEN_ACMDCRCERR |
- MSDC_INTEN_ACMDTMO);
+ sdr_clr_bits(host->base + MSDC_INTEN, cmd_ints_mask);
if (cmd->flags & MMC_RSP_PRESENT) {
if (cmd->flags & MMC_RSP_136) {
@@ -818,10 +818,7 @@ static void msdc_start_command(struct msdc_host *host,
rawcmd = msdc_cmd_prepare_raw_cmd(host, mrq, cmd);
mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT);
- sdr_set_bits(host->base + MSDC_INTEN, MSDC_INTEN_CMDRDY |
- MSDC_INTEN_RSPCRCERR | MSDC_INTEN_CMDTMO |
- MSDC_INTEN_ACMDRDY | MSDC_INTEN_ACMDCRCERR |
- MSDC_INTEN_ACMDTMO);
+ sdr_set_bits(host->base + MSDC_INTEN, cmd_ints_mask);
writel(cmd->arg, host->base + SDC_ARG);
writel(rawcmd, host->base + SDC_CMD);
}
--
1.8.1.1.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/10] Add tune support of Mediatek MMC driver Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 03/10] mmc: mediatek: make cmd_ints_mask to const Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 10/10] arm64: dts: mediatek: add HS200/HS400/SDR50/SDR104 support Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 01/10] mmc: core: Add DT bindings for eMMC hardware reset support Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 05/10] mmc: mediatek: fix got GPD checksum error interrupt when data transfer Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 04/10] mmc: mediatek: change the argument "ddr" to "timing" Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 [PATCH v3 08/10] mmc: mmc: extend the mmc_send_tuning() Chaotian Jing <chaotian.jing@mediatek.com> - 2015-10-27 07:30 +0100 Re: [PATCH v3 00/10] Add tune support of Mediatek MMC driver Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-27 11:00 +0100
csiph-web