Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256489

Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator

Show all headers | View raw

Hello Mark,

Am 27.10.2015 um 03:12 schrieb Mark Brown:
> On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
>> add DT support for the tps6502x regulators.
>
> Please use subject lines matching the style for the subsystem.

Would be "regulator: tps6520x:" correct?

>> +	regulators = of_get_child_by_name(np, "regulators");
>> +	if (!regulators) {
>> +		dev_err(dev, "regulator node not found\n");
>> +		return NULL;
>> +	}
>
> Please use the generic support for locating the DT information for
> regulators using regulators_node and of_match in the regulator_desc
> rather than open coding this.

Hmm.. could you point me to a correct example? Seems I overlook sth.

drivers/regulator/tps65090-regulator.c
drivers/regulator/tps65910-regulator.c
drivers/regulator/tps6507x-regulator.c
drivers/regulator/tps6586x-regulator.c

are doing it all the same way ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] regulator, dt: add dt support for tps6502x regulator Heiko Schocher <hs@denx.de> - 2015-10-26 12:30 +0100
  Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator Mark Brown <broonie@kernel.org> - 2015-10-27 03:20 +0100
    Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator Heiko Schocher <hs@denx.de> - 2015-10-27 07:30 +0100
      Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator Mark Brown <broonie@kernel.org> - 2015-10-27 08:30 +0100

csiph-web